Merged
Conversation
- Set inside_link_block for Inline and Reference link types to prevent text extraction - Prioritize inside_link_block check to skip text extraction when inside any link - Add comprehensive test test_link_text_not_checked() to verify fix Fixes issue where [broken-url](good-url) would check both broken-url and good-url instead of just checking the destination good-url. Fixes: #1579
- Respect `include_verbatim` flag when processing link text - Fix WikiLink double extraction by using separate tracking - Add tests for link text extraction behavior
Member
Author
|
@dbr, it's been a very long time. So sorry for the delay. I'm not sure if you're still interested in the fix. |
|
Great, thanks for this! |
This was referenced Oct 21, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, links inside Markdown link texts get parsed and handled.
For example:
This would find https://dummyexample.gov/notexist.
This PR changes that and ignores those links unless the user explicitly enabled the check by setting
--include-verbatim.This is similar to the handling of HTML files. See #1399.
Wikilinks behaved slightly differently and would be extracted twice when
--include-verbatimwas enabled - once from the WikiLink tag itself (which contains the destination URL) and once from the text content within the WikiLink. This caused duplicate URL entries in the output. That's why I introduced a separate flag for that.Fixes: #1579
Details
include_verbatimflag when processing link text