Extract spans for URIs.#1806
Closed
Akida31 wants to merge 1 commit intolycheeverse:masterfrom
Akida31:master
Closed
Extract spans for URIs.#1806Akida31 wants to merge 1 commit intolycheeverse:masterfrom Akida31:master
Akida31 wants to merge 1 commit intolycheeverse:masterfrom
Akida31:master
Conversation
This can be used in the future to add line numbers and columns in output. Note that the html5ever extractor does not output column information, since currently there is no way to retrieve it.
Member
|
@Akida31 Thanks a lot for your efforts on both html5gum and this PR, really appreciate it! |
Member
|
@thomas-zahner, would you have some time for the rebase and the review you mentioned? Would be nice to merge it in. 😊 |
Merged
Member
|
Closing in favor of #1870 which is a copy of this but rebased to master and a few small changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got nerd-sniped in #1304 and implemented the extraction of line and column numbers of links.
Note that it doesn't display them in the cli output for now, and I currently don't have plans to implement that.
Feel free to push to this PR or subsume it.