Fix possible outputs of 'arch' command in Alpine Linux-based Dockerfile#1778
Conversation
|
@mre @willnode Could you review? The way to know this is it the correct fix is (assuming Docker is set up locally):
With this change, I can also locally build a Docker image with the Alpine Linux Docker file for the docker buildx build --platform "linux/amd64" --file Dockerfile-CI.alpine.Dockerfile .Building for docker buildx build --platform "linux/arm64" --file Dockerfile-CI.alpine.Dockerfile .If we run
It is likely that when the next release happens, this problem will go away. I haven't really looked into if this should be the expected behavior (wanting both "latest" and "latest released"). |
|
I didn't test it locally, but given that the setup is broken in master right now and that this PR reverts to the previous behavior, I'd say it's fine to merge. |
Thanks @mre. Do you think a new release is far away? |
|
I hope to get a release out after the next batch of fixes/features which are still open. Would like to at least update the dependencies before. #1779 |
|
@mre @thomas-zahner I managed to figure out the problem I was having locally (#1778 (comment)). When If I update the Docker file to access the nightly when I've raised a pull request (#1802) in case you want that behavior for the project. |
A follow up to: #1774.
That pull request seemed to correctly provide a new
lychee-aarch64-unknown-linux-musl.tar.gzbuild (see nightly: https://github.com/lycheeverse/lychee/releases/tag/nightly), but incorrectly changed what the expected output from Alpine Linux'sarchcommand was.This pull request restores the original parsing of the output, but retains the new format of what is set in
$ARCHfor use later. It might be possible to further refine the Dockerfile, but the intention here is to make as few changes as possible each time.