Replace unmaintained human-sort with numeric-sort#1759
Merged
mre merged 3 commits intolycheeverse:masterfrom Jul 4, 2025
Merged
Replace unmaintained human-sort with numeric-sort#1759mre merged 3 commits intolycheeverse:masterfrom
mre merged 3 commits intolycheeverse:masterfrom
Conversation
human-sort is unmaintained and causes panic in recent Rust versions. This commit replaces all usages of human_sort::compare with numeric_sort::cmp to fix the 'total order' panic issue. Fixes lycheeverse#1758
mre
reviewed
Jul 4, 2025
| sorted_suggestions.sort_by(|a, b| { | ||
| let (a, b) = (a.to_string().to_lowercase(), b.to_string().to_lowercase()); | ||
| human_sort::compare(&a, &b) | ||
| cmp(&a, &b) |
Member
There was a problem hiding this comment.
There is std::cmp. Can we use the fully qualified name here to avoid the naming confusion?
Suggested change
| cmp(&a, &b) | |
| numeric_sort::cmp(&a, &b) |
mre
reviewed
Jul 4, 2025
| sorted_suggestions.sort_by(|a, b| { | ||
| let (a, b) = (a.to_string().to_lowercase(), b.to_string().to_lowercase()); | ||
| human_sort::compare(&a, &b) | ||
| cmp(&a, &b) |
Member
|
Thanks for the PR. Added some comments. |
|
@mre
This should make it clear that we're using the numeric_sort function rather than the std module. |
Member
|
Yup, that makes perfect sense. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1758
Replaces the unmaintained
human-sortcrate withnumeric-sortto fix panic issues in recent Rust versions.Problem
human-sortis unmaintainedSolution
human-sort(0.2.2) withnumeric-sort(0.1.5)human_sort::comparetonumeric_sort::cmpChanges
Cargo.tomldependencylychee-bin/src/formatters/stats/mod.rslychee-bin/src/formatters/stats/compact.rslychee-bin/src/formatters/stats/detailed.rsTesting
cargo buildpasses without errorscargo testpasses