Conversation
…tChain & remove headers from Input
thomas-zahner
commented
Jun 27, 2025
Member
Author
|
Pipeline fails because of Rust 1.88 was released yesterday with new clippy suggestions. See: #1749 |
Member
|
#1749 is merged so you can rebase 👍 |
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
mre
reviewed
Jun 27, 2025
Member
mre
left a comment
mre
left a comment
There was a problem hiding this comment.
Great progress! Added a few comments.
Co-authored-by: Matthias Endler <matthias@endler.dev>
thomas-zahner
force-pushed
the
fix-basic-auth
branch
from
b164304 to
c694daf
Compare
thomas-zahner
force-pushed
the
fix-basic-auth
branch
from
cfc84ac to
89e9a18
Compare
mre
reviewed
Jun 28, 2025
Member
mre
left a comment
mre
left a comment
There was a problem hiding this comment.
Done with the review for now. Added another comment. 😄
Member
Author
|
@mre Thanks, the code is now quite a bit simpler. What do you think? |
Member
|
Very nice! |
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've captured the bug by updating the test in 997f1f7
Closes #1495