Fix aarch64 build in Dockerfile-CI.alpine.Dockerfile#1747
Conversation
|
I'm not sure that will working since alpine doesn't have glibc, it must be compiled under musl. |
|
Okay, I'm not an expert on this but the binary builds are here if you want to give it a go: https://github.com/lycheeverse/lychee/blob/master/.github/workflows/release-binary.yml Maybe it's possible to create a PR for that new binary? |
|
AFAIK That would be a breaking change I think |
|
Breaking change would be fine. The image is broken anyway at the moment. ;) |
|
@willnode , do you think the change is correct and fixes the problem? If not, I'd need some guidance here. Not an expert. 😉 If there's a better way, I'd appreciate a pull request or a list of change requests. |
|
I'll test tonight |
@willnode Did you have any luck with your testing? |
| && ARCH=$(case $(arch) in \ | ||
| "x86_64") echo "x86_64-unknown-linux-musl";; \ | ||
| "aarch64") echo "arm-unknown-linux-musleabihf";; \ | ||
| "aarch64") echo "aarch64-unknown-linux-gnu";; \ |
There was a problem hiding this comment.
You're right. If you like, you could create a separate pr to try and fix it.
|
@mre I'm wondering with this one if the problem is the binary itself. If I'm not mistaken, this project uses https://github.com/cross-rs/cross for compilation, and uses a subset of https://github.com/cross-rs/cross?tab=readme-ov-file#supported-targets as compilation targets: lychee/.github/workflows/release-binary.yml Lines 43 to 49 in e743ea3 I wonder if adding |
I've raised: #1774 to that effect. |
|
Closing because it got superseded #1774. |
Fixes #1745