Skip to content

Add xml schema found in xsd files to list of exclusions#1735

Merged
mre merged 2 commits intolycheeverse:masterfrom
tooomm:patch-1
Jun 20, 2025
Merged

Add xml schema found in xsd files to list of exclusions#1735
mre merged 2 commits intolycheeverse:masterfrom
tooomm:patch-1

Conversation

@tooomm
Copy link
Contributor

@tooomm tooomm commented Jun 16, 2025

Linking lycheeverse/lychee-action#297


Should the dots in the regex be escaped to match explicitly? @mre Done, 93090c3

@thomas-zahner
Copy link
Member

thomas-zahner commented Jun 18, 2025

Thanks for the PR. You are right, we should escape all . in URLs. A false positive is quite unlikely but technically it's still incorrect to not escape them. Can you escape all URLs in the FALSE_POSITIVE_PAT slice?

In our documentation it is also explained like that: https://lychee.cli.rs/recipes/excluding-links/#advanced-examples

@mre
Copy link
Member

mre commented Jun 20, 2025

Looks good, thanks @tooomm and thanks for the review @thomas-zahner.

@mre mre merged commit 83fe124 into lycheeverse:master Jun 20, 2025
6 checks passed
@mre mre mentioned this pull request Jun 20, 2025
@tooomm tooomm deleted the patch-1 branch June 20, 2025 14:18
This was referenced Jul 3, 2025
@mre mre mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants