Skip to content

display unsupported URLs#1727

Merged
mre merged 2 commits intolycheeverse:masterfrom
AllenSH12:ash/unsupported-urls
Jun 20, 2025
Merged

display unsupported URLs#1727
mre merged 2 commits intolycheeverse:masterfrom
AllenSH12:ash/unsupported-urls

Conversation

@AllenSH12
Copy link
Contributor

@AllenSH12 AllenSH12 commented Jun 12, 2025

Summary

Addresses #1703 but uses the existing "unsupported" status instead of introducing an "Ignored" row.

Testing

$ cat urls
git+https://github.com/pyvista/pyvista.git@main
https://lodash.com/docs/latest#get

$ git rev-parse --short head
4bc0cac

$ cargo build

Compact

$ ./target/debug/lychee urls                            
  2/2 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                        Issues found in 1 input. Find details below.

[urls]:
     [404] https://lodash.com/docs/latest#get | Rejected status code (this depends on your "accept" configuration): Not Found

🔍 2 Total (in 0s) ✅ 0 OK 🚫 1 Error ⛔ 1 Unsupported

Detailed

$ ./target/debug/lychee --format detailed urls
  2/2 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                        
📝 Summary
---------------------
🔍 Total............2
✅ Successful.......0
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in urls
     [404] https://lodash.com/docs/latest#get | Rejected status code (this depends on your "accept" configuration): Not Found

JSON

$ ./target/debug/lychee --format json urls
  2/2 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                        {
  "total": 2,
  "successful": 0,
  "unknown": 0,
  "unsupported": 1, # 💚 always had it
  "timeouts": 0,
  "redirects": 0,
  "excludes": 0,
  "errors": 1,
  "cached": 0,
  "success_map": {},
  "error_map": {
    "urls": [
      {
        "url": "https://lodash.com/docs/latest#get",
        "status": {
          "text": "Rejected status code (this depends on your \"accept\" configuration)",
          "code": 404
        }
      }
    ]
  },
  "suggestion_map": {},
  "excluded_map": {},
  "duration_secs": 0,
  "detailed_stats": false
}

Markdown

$ ./target/debug/lychee --format markdown urls
  2/2 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                                                                                        ```
# Summary

| Status         | Count |
|----------------|-------|
| 🔍 Total       | 2     |
| ✅ Successful  | 0     |
| ⏳ Timeouts    | 0     |
| 🔀 Redirected  | 0     |
| 👻 Excluded    | 0     |
| ❓ Unknown     | 0     |
| 🚫 Errors      | 1     |
| ⛔ Unsupported | 1     |

## Errors per input

### Errors in urls

* [404] <https://lodash.com/docs/latest#get> | Rejected status code (this depends on your "accept" configuration): Not Found

@AllenSH12 AllenSH12 marked this pull request as ready for review June 12, 2025 02:33
@AllenSH12 AllenSH12 marked this pull request as draft June 12, 2025 02:35
@AllenSH12 AllenSH12 force-pushed the ash/unsupported-urls branch from a2920f1 to 4bc0cac Compare June 12, 2025 02:40
@AllenSH12
Copy link
Contributor Author

Thank you for creating this tool, appreciate the simple UX and inclusion of the gh action as an artifact and looking forward to using this more!

If there is anything I should follow up on please let me know 🙏

@AllenSH12 AllenSH12 marked this pull request as ready for review June 12, 2025 03:01
@mre
Copy link
Member

mre commented Jun 20, 2025

Looks great. Thanks a lot!

@mre mre merged commit bbfb8b0 into lycheeverse:master Jun 20, 2025
6 checks passed
@thomas-zahner
Copy link
Member

@AllenSH12 Thank you for the PR 👍

This was referenced Jul 3, 2025
@mre mre mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants