Skip to content

fix: only check fragments inside files#1713

Merged
mre merged 4 commits intolycheeverse:masterfrom
kemingy:only_check_file_fragment
May 23, 2025
Merged

fix: only check fragments inside files#1713
mre merged 4 commits intolycheeverse:masterfrom
kemingy:only_check_file_fragment

Conversation

@kemingy
Copy link
Contributor

@kemingy kemingy commented May 23, 2025

What's in this PR:

  • only check fragments for files
  • better err type
  • more info in err msg

BTW, I'm not sure if the Client.check_fragment is used by any caller. cc @mre

kemingy and others added 4 commits May 23, 2025 23:49
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
@mre
Copy link
Member

mre commented May 23, 2025

You're right, I think we can clean that up. Nice catch!
(Guess it was still in there because it belongs to the public API, but we don't have a stable API yet and its better to clean it up before we stabilize.)

@mre mre merged commit 208fa80 into lycheeverse:master May 23, 2025
6 checks passed
@mre
Copy link
Member

mre commented May 23, 2025

Thanks for the quick turnaround on this one! Can you post a comment in the linked issue?

@mre mre mentioned this pull request May 23, 2025
@kemingy
Copy link
Contributor Author

kemingy commented May 24, 2025

Thanks for the quick turnaround on this one! Can you post a comment in the linked issue?

Sure.

@kemingy kemingy deleted the only_check_file_fragment branch May 24, 2025 00:02
@mre mre mentioned this pull request May 25, 2025
@thomas-zahner thomas-zahner changed the title fix: only check the fragment when it's a file fix: only check the fragments inside files Jun 11, 2025
@thomas-zahner thomas-zahner changed the title fix: only check the fragments inside files fix: only check fragments inside files Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants