fix: ignore gitlab table of content in wikilinks#1710
Merged
mre merged 2 commits intolycheeverse:masterfrom May 23, 2025
JayJayArr:#1708
Merged
fix: ignore gitlab table of content in wikilinks#1710mre merged 2 commits intolycheeverse:masterfrom JayJayArr:#1708
mre merged 2 commits intolycheeverse:masterfrom
JayJayArr:#1708
Conversation
mre
reviewed
May 22, 2025
Comment on lines
+68
to
+71
| //Ignore gitlab toc notation: https://docs.gitlab.com/user/markdown/#table-of-contents | ||
| if ["_TOC_".to_string(), "TOC".to_string()].contains(&dest_url.to_string()) { | ||
| return None; | ||
| } |
Member
There was a problem hiding this comment.
Not sure, but have you tried
if ["_TOC_", "TOC"].contains(&dest_url.as_str()) {Would save a few allocs.
Contributor
Author
There was a problem hiding this comment.
Sounds very good!
...but is apparently not stabilized yet: rust-lang/rust#130366
Is would be possible with as_ref like
if ["_TOC_", "TOC"].contains(&dest_url.as_ref()) {but this might break in the future: rust-lang/rust#130366 (comment)
Member
There was a problem hiding this comment.
Wow, you really did some soul-searching to dig this up. Nice research. ❤️
All good then.
Member
|
Thanks for the fix! One little thingy. 😃 |
mre
reviewed
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1708