Skip to content

Specify MSRV#1676

Merged
thomas-zahner merged 3 commits intolycheeverse:masterfrom
kemingy:clippy_oncecell
May 9, 2025
Merged

Specify MSRV#1676
thomas-zahner merged 3 commits intolycheeverse:masterfrom
kemingy:clippy_oncecell

Conversation

@kemingy
Copy link
Contributor

@kemingy kemingy commented Apr 11, 2025

  • replace once_cell::sync::Lock with std::sync::LazyLock
  • remove some useless ;
  • mark some functions as const
  • add MSRV

Signed-off-by: Keming <kemingy94@gmail.com>
@thomas-zahner
Copy link
Member

thomas-zahner commented May 9, 2025

Thank you very much for the PR. Someone else created an almost identical PR #1681 which I saw first. So this PR now boils down to the MSRV. The version you have set seems to be pretty high. Is this the lowest version the project still compiles?

@kemingy
Copy link
Contributor Author

kemingy commented May 9, 2025

The msrv is generated by https://github.com/foresterre/cargo-msrv

You can verify with this tool.

@thomas-zahner
Copy link
Member

Awesome, I didn't know about the tool. I also got 1.83.0.
Could you update the PR to just include the MSRV?

kemingy added 2 commits May 9, 2025 21:42
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
Copy link
Contributor Author

kemingy commented May 9, 2025

Awesome, I didn't know about the tool. I also got 1.83.0. Could you update the PR to just include the MSRV?

fixed. PTAL

@thomas-zahner thomas-zahner changed the title fix: replace once_cell to make cargo clippy happy Specify MSRV May 9, 2025
@thomas-zahner thomas-zahner merged commit 809958b into lycheeverse:master May 9, 2025
6 checks passed
@thomas-zahner
Copy link
Member

Looks good. Thank you!

@mre mre mentioned this pull request May 9, 2025
@mre
Copy link
Member

mre commented May 9, 2025

Nice. @kemingy, maybe you'd like to create a follow-up pull request to verify that the MSRV is correct in CI? Basically call
https://gribnau.dev/cargo-msrv/commands/verify.html in https://github.com/lycheeverse/lychee/blob/master/.github/workflows/ci.yml (or perhaps in a separate pipeline that runs regularly; up to you.

@kemingy kemingy deleted the clippy_oncecell branch May 13, 2025 07:20
@mre mre mentioned this pull request May 13, 2025
@mre mre mentioned this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants