Conversation
Signed-off-by: Keming <kemingy94@gmail.com>
|
Thank you very much for the PR. Someone else created an almost identical PR #1681 which I saw first. So this PR now boils down to the MSRV. The version you have set seems to be pretty high. Is this the lowest version the project still compiles? |
|
The msrv is generated by https://github.com/foresterre/cargo-msrv You can verify with this tool. |
|
Awesome, I didn't know about the tool. I also got |
Signed-off-by: Keming <kemingy94@gmail.com>
fixed. PTAL |
|
Looks good. Thank you! |
|
Nice. @kemingy, maybe you'd like to create a follow-up pull request to verify that the MSRV is correct in CI? Basically call |
once_cell::sync::Lockwithstd::sync::LazyLock;const