Conversation
Member
|
@HU90m, sorry, I lost track of this. Can you rebase on top of |
Contributor
Author
|
No worries! Just rebased it now |
mre
reviewed
May 10, 2025
lychee-bin/src/options.rs
Outdated
| #[serde(default = "max_retries")] | ||
| pub(crate) max_retries: u64, | ||
|
|
||
| // Minimum TLS Version |
Member
There was a problem hiding this comment.
Sorry for not noticing sooner, but if you change this to /// then it will become part of the documentation. (I noticed because I wondered why the argument in the updated README.md didn't contain a help message.)
Suggested change
| // Minimum TLS Version | |
| /// Minimum TLS Version |
Member
|
Thanks! ✌️ |
Closed
mre
added a commit
that referenced
this pull request
May 10, 2025
mre
added a commit
that referenced
this pull request
May 10, 2025
mre
added a commit
that referenced
this pull request
May 10, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature suggested in: #1232