Refactor input dumping and path retrieval with extension filtering#1648
Refactor input dumping and path retrieval with extension filtering#1648
Conversation
thomas-zahner
left a comment
There was a problem hiding this comment.
Whew, that's quite a lot of changes. I didn't check every single detail nor did I test it locally. Are the existing tests covering the changes? I just see that you made a lot of changes and didn't add any tests but removed some.
|
From my side, this is ready to be merged. I changed The Docker image is currently failing because of #1774 and I hope it will be fixed with the next lychee release (0.20.0). |
thomas-zahner
left a comment
There was a problem hiding this comment.
Looks great 👍 and actually fixes #1767
…dling. Rebase on top of `master`
… in get_file_paths method
…umentation accordingly
fe6e4ef to
99ee4df
Compare
|
Here I was, thinking that this would be a 10-minute change. So many edge-cases and caveats (and distractions, I guess)! Anyway, this is finally ready now. As always, thanks for the thoughtful review @thomas-zahner. |
Refactor the
dump-inputsfunctionality to print all files checked for links and implement file path retrieval with extension filtering in theInputmodule.I added this because it was hard to troubleshoot the extension changes, but I figured it would also be helpful to people who want to see which files would be checked when they write
lychee ..As an added benefit,
dump-inputsnow behaves more like thecheckcommand and properly ignores hidden files etc.This is a follow-up to #1559.
Closes #1767.