renamed base to base_url (fixes #1607)#1629
Merged
mre merged 8 commits intolycheeverse:masterfrom Feb 16, 2025
Merged
Conversation
mre
reviewed
Feb 10, 2025
mre
reviewed
Feb 10, 2025
mre
reviewed
Feb 10, 2025
mre
reviewed
Feb 10, 2025
Co-authored-by: Matthias Endler <matthias@endler.dev>
Co-authored-by: Matthias Endler <matthias@endler.dev>
mre
reviewed
Feb 14, 2025
Member
|
Just one final remark; rest of the code looks fine. |
Contributor
Author
|
well I actually don't know why this test fails... |
Member
|
I think it's just a network blip. Let's retry! |
Member
|
Hum, no. The example.com website is up, so no clue. It's unrelated to your changes, but it would be nice to get that green tick. I can merge it if you like or we try again later. |
Contributor
Author
|
Haha idk, weird i can Check tomorrow |
Closed
Member
|
It was just a network issue. Now fixed. Thanks for the pull request! 😃 |
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the configuration parameter
basetobase_urlto improve clarity (fixes #1607)