Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Typescript work out of the box #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make Typescript work out of the box #52

wants to merge 2 commits into from

Conversation

kcirtaptrick
Copy link

@kcirtaptrick kcirtaptrick commented May 23, 2021 •
edited
Loading

MERGE #51 FIRST

  • Adds @types/webpack-env package for module.hot types
  • Remove filename from entrypoints to make Webpack choose defaults. This will choose any index file instead of just .js/jsx
  • Add src/types.d.ts with asset and css module

@kcirtaptrick
Fix sass + GYP error
1b9c854 
Replaces node-sass with sass package to resolve GYP error
@kcirtaptrick
Make Typescript work out of the box
11f7407
jhserodio
jhserodio reviewed Aug 12, 2022
View reviewed changes
.gitignore
@@ -19,3 +19,6 @@

# secrets
secrets.*.js

# editor configs
/.vscode
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope of task.

jhserodio
jhserodio reviewed Aug 12, 2022
View reviewed changes
package.json
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-hot-loader": "^4.13.0"
"react-hot-loader": "^4.13.0",
"sass": "^1.34.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already exist a PR for add sass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhserodio jhserodio jhserodio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcirtaptrick @jhserodio