Add comment about devtools_page permissions request to manifest.json
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you include `devtools_page` in your extension manifest, your extension will show the following permissions warning on install: - Read and change all your data on all websites I wasted quite some time trying to figure out why I was getting this warning—it's hardly obvious that the `devtools_page` thing would trigger it. I suggest adding a comment about this, or else removing the line completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you include
devtools_pagein your extension manifest, the extension will show the following permissions warning on install:I wasted quite some time trying to figure out why I was getting this warning—it's not obvious that the
devtools_pagething would trigger it.I suggest adding a comment about this, or else removing the line completely.