Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incusd/instance/qemu: rtc base localtime for windows #1767

Merged
merged 3 commits into from
Mar 14, 2025
Merged

incusd/instance/qemu: rtc base localtime for windows #1767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
727bdc4
incusd/instance/qemu: Move Windows check to a function
nanjj Mar 14, 2025
387d053
incusd/instance/qemu: Set RTC base to localtime on Windows
nanjj Mar 14, 2025
4a56581
doc/instance/create: Cover behavior on Windows
stgraber Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/.wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ RESTful
RHEL
rootfs
RSA
RTC
rST
runtime
SATA
Expand Down
10 changes: 10 additions & 0 deletions doc/howto/instances_create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,16 @@ The list of supported clouds and instance types can be found at [`https://github

### Launch a VM that boots from an ISO

```{note}
When creating a Windows virtual machine, make sure to set the `image.os` property to something starting with `Windows`.
Doing so will tell Incus to expect Windows to be running inside of the virtual machine and to tweak behavior accordingly.

This notably will cause:
- Some unsupported virtual devices to be disabled
- The {abbr}`RTC (Real Time Clock)` clock to be based on system local time rather than UTC
- IOMMU handling to switch to an Intel IOMMU controller
```

To launch a VM that boots from an ISO, you must first create a VM.
Let's assume that we want to create a VM and install it from the ISO image.
In this scenario, use the following command to create an empty VM:
Expand Down
12 changes: 11 additions & 1 deletion internal/server/instance/drivers/driver_qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1624,6 +1624,11 @@ func (d *qemu) start(stateful bool, op *operationlock.InstanceOperation) error {
}
}

// Set RTC to localtime on Windows.
if d.isWindows() {
qemuArgs = append(qemuArgs, "-rtc", "base=localtime")
}

// SMBIOS only on x86_64 and aarch64.
if d.architectureSupportsUEFI(d.architecture) {
qemuArgs = append(qemuArgs, "-smbios", "type=2,manufacturer=LinuxContainers,product=Incus")
Expand Down Expand Up @@ -3340,11 +3345,16 @@ func (d *qemu) deviceBootPriorities(base int) (map[string]int, error) {
return sortedDevs, nil
}

// isWindows returns whether the VM is Windows.
func (d *qemu) isWindows() bool {
return strings.Contains(strings.ToLower(d.expandedConfig["image.os"]), "windows")
}

// generateQemuConfig generates the QEMU configuration.
func (d *qemu) generateQemuConfig(cpuInfo *cpuTopology, mountInfo *storagePools.MountInfo, busName string, vsockFD int, devConfs []*deviceConfig.RunConfig, fdFiles *[]*os.File) ([]monitorHook, error) {
var monHooks []monitorHook

isWindows := strings.Contains(strings.ToLower(d.expandedConfig["image.os"]), "windows")
isWindows := d.isWindows()
conf := qemuBase(&qemuBaseOpts{d.Architecture(), util.IsTrue(d.expandedConfig["security.iommu"])})

err := d.addCPUMemoryConfig(&conf, cpuInfo)
Expand Down