Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored SeriesDtTransformer tests #329

Merged
merged 3 commits into from
Oct 15, 2024
Merged

refactored SeriesDtTransformer tests #329

merged 3 commits into from
Oct 15, 2024

Conversation

limlam96
Copy link
Contributor

#299

Note, changes 'column' arg to 'columns' to fit general API format

Copy link
Collaborator

@Chip2916 Chip2916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments :)

tubular/dates.py Outdated Show resolved Hide resolved
tubular/dates.py Show resolved Hide resolved
tests/dates/test_SeriesDtMethodTransformer.py Show resolved Hide resolved
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@Chip2916 Chip2916 merged commit a985254 into main Oct 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants