🐛 fixed bug with get_params method when capping_values=None #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue raised in #292
Moved setting of self.capping_values out of conditional block so it still happens when capping_values= None.
The lack of a capping_values attribute was causing issues with the get_params method inherited from sklearn.
Added a test for just this transformer. Arguably should add for rest of package too via base_tests.OtherBaseBehaviour but this would be more involved as it requires iterating through all optional attributes set to None. I suspect this would require a configuration somewhere as there are probably quite a few cases where args cannot be optional at the same time.