298 refactor DatetimeSinusoidCalculator tests #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SinusoidCalculator
davidhopkinson26
changed the title
limlam96
reviewed
Oct 9, 2024
|
|
||
| class TestDatetimeSinusoidCalculatorTransform: | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
Think we can delete the date col check on line 248
There was a problem hiding this comment.
yep agree b897d28
|
have the classic changelog conflicts fyi |
limlam96
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tests for DattimeSinusoidCalculator to new regime
also fixed a couple of tests in test_BaseDatetimeTransformer and test_BaseGenericDateTransformer to make them compatible with other classes as they had specific initialisation arguments in the tests.