Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor datediffleap tests #306

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

limlam96
Copy link
Contributor

testing refactor #295

Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes. I think dropping the default new_column_name is ok for now as I haven't seen it used much. Happy to sacrifice that in the name of getting the test refactor done.

@limlam96 limlam96 merged commit c42ac41 into main Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants