Feature/basedate tests #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubular/dates.py
Outdated
| msg = f"{self.classname()}: {col} type should be in {allowed_types} but got {X[col].dtype}" | ||
| col_dtype = date_type if is_date else X[col].dtype | ||
|
|
||
| msg = f"{self.classname()}: {col} type should be in {allowed_types} but got {col_dtype}" | ||
| raise TypeError(msg) | ||
|
|
||
| present_types = set(type_dict.values()) | ||
|
|
||
| only_datetime_present = present_types == {datetime_type} |
There was a problem hiding this comment.
S: I think this bit of logic might be cleaned up a bit by comparing present_types to set(allowed_types)?
There was a problem hiding this comment.
good shout, updated here ae94c55
davidhopkinson26
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit some issues testing the datetime only transformers, so did a slight rework of the base class/base test setup to make generic date vs just datetime transformers less coupled