Feature/two column operator #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubular/numeric.py
Outdated
|
|
||
| self.column1_name = columns[0] | ||
| self.column2_name = columns[1] | ||
| # Set above call to super as DFMTransformer accepts columns, but this transformer only ever needs one |
There was a problem hiding this comment.
'Set below call'? I'm not quite sure what you mean here, this transformer needs two columns?
There was a problem hiding this comment.
Hopefully this comment makes it clearer!
| @@ -419,7 +420,7 @@ def transform(self, X: pd.DataFrame) -> pd.DataFrame: | |||
| msg = f"{self.classname()}: input columns in X must contain only numeric values" | |||
There was a problem hiding this comment.
N: noticed an error on line 414:
'# call BaseTransformer.transform
X = super(DataFrameMethodTransformer, self).transform(X)'
davidhopkinson26
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored TwoColumnOperator to align with new test design.
Linked issue here