-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/string transformer refactor #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a case could be made for creating a test class for single column input transformers but since this is the only one it is pretty thin. Overwriting like this for one off exceptions is the intended use of the test framework.
Happy with changes, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My changes approved by David, who has then resolved merge conflicts, happy with this change.
Changes to update StringConcatenator and SeriesStrMethodTransformer tests to bring in line with new testing structure.
Issues: 278 and 279