Feature/nearestmeanresponse update #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limlam96
reviewed
Jul 19, 2024
| msg="Check nulls filled correctly in transform", | ||
| ) | ||
|
|
||
| def test_learnt_values_not_modified(self): |
There was a problem hiding this comment.
Q: do we not need this one?
There was a problem hiding this comment.
Hey Liam - is this not covered by the 'test_impute_value_unchanged' test in the 'test_BaseImputer' script?
limlam96
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to this issue.
Brought nearest mean response tests in line with new framework. Had to make very small change to minimal_dataframe_lookup function in conftest as NMI transformer requires a dataframe where columns have some nans in order to pass generic tests.
Also added in minor error handling step in the imputer script itself, as the default value for the y parameter is None which falls over immediately as one of the first steps in fit is 'y.isna()' and None has no 'isna' attribute.
Also overwrote 'test_fit_not_changing_data' in generic tests in the NMI specific tests scripts as base test for 'test_fit_not_changing_data' is set up without a y value being called in fit, which works fine for other transformers but not for NMI.