-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
256 all configs within pyprojecttoml for a streamlined build experience #271
Merged
davidhopkinson26
merged 31 commits into
main
from
256-all-configs-within-pyprojecttoml-for-a-streamlined-build-experience
Aug 5, 2024
Merged
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3bf75bd
:sparkles: moved ruff and coverage config to pyproject.toml
davidhopkinson26 fdc7e4c
:fire: delete redundant config files
davidhopkinson26 7dc3d1c
add build-system and project secitons to pyproject.toml
davidhopkinson26 b9ad64f
bug fixes and adding [dev] optional dependencies
davidhopkinson26 5ea9a0b
:fire: delete requirements files
davidhopkinson26 015002a
Revert ":fire: delete requirements files"
davidhopkinson26 41afadb
:fire: removed dev dependency spec from pyproject.toml
davidhopkinson26 e99d4b8
:fire: deleted requirements.txt
davidhopkinson26 467400f
:construction: edits to release.yml to use build
davidhopkinson26 d041460
:bug: fixes to format in pyproject.toml for build to run
davidhopkinson26 7d331ce
:bug: adds requirements.txt back in
davidhopkinson26 f2189d9
separate calls to build --sdist and build --wheel
davidhopkinson26 b3cdfd7
Revert "separate calls to build --sdist and build --wheel"
davidhopkinson26 60a7e0d
:fire: point publish to pypi not testpypi
davidhopkinson26 387d947
:art: define requirements in pyproject.toml and use pip-compile to cr…
davidhopkinson26 85dde0c
removed python 3.12 from python-package.yml matrix as conflicts with …
davidhopkinson26 117a218
:construciton: adds pip compile to build pipeline and puts python 3.1…
davidhopkinson26 46cda92
:construction: swithc to using uv for compile in build pipeline
davidhopkinson26 90e8ac4
:construction: adds dev to pip compile command in build pipeline
davidhopkinson26 59f857d
:construction: install directly from pyproject.toml
davidhopkinson26 6aaee4c
:bug: fix code rendering in CONTRIBUTING.rst
davidhopkinson26 2e21ad6
:art: moved build install into Install dependencies step
davidhopkinson26 3942b60
:art: cleaned up old comments
davidhopkinson26 1e0bbf1
:fire: removed setup.py
davidhopkinson26 fad971f
:fire: removed requirements.txt
davidhopkinson26 81961d2
:sparkles: implements setuptools-scm to do dynamic versioning
davidhopkinson26 a9972f2
:bug: fixed import of version into base.py
davidhopkinson26 aff5f87
:fire: removed self.version setting as not used anywhere
davidhopkinson26 c066cef
u:memo: pdated Changelog
davidhopkinson26 d964161
Merge branch 'main' into 256-all-configs-within-pyprojecttoml-for-a-s…
davidhopkinson26 5b80647
:bug: removed version import form base.py
davidhopkinson26 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
[build-system] | ||
requires = [ | ||
"setuptools >= 61.0", | ||
"wheel", | ||
"setuptools-scm[toml]>=6.0" | ||
] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "tubular" | ||
version = "1.3.1" | ||
dependencies = [ | ||
"pandas>=1.5.0", | ||
"scikit-learn>=1.2.0" | ||
] | ||
requires-python = ">=3.8" | ||
authors = [{ name = "LV GI Data Science Team", email="#[email protected]"}] | ||
description = "Package to perform pre processing steps for machine learning models" | ||
readme = {file = "README.md", content-type = "text/markdown"} | ||
license = {file = "LICENSE"} | ||
keywords = ["data science", "feature engineering", "data transforms", "pipeline", "sklearn", "machine learning", "ML", "DS"] | ||
classifiers=[ | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Operating System :: OS Independent", | ||
"License :: OSI Approved :: BSD License", | ||
] | ||
|
||
[project.optional-dependencies] | ||
dev = [ | ||
"test-aide>=0.1.0", | ||
"pytest>=5.4.1", | ||
"pytest-mock>=3.5.1", | ||
"pytest-cov>=2.10.1", | ||
"pre-commit==2.15.0 ", | ||
"ruff==0.2.2", | ||
] | ||
|
||
[project.urls] | ||
Documentation = "https://tubular.readthedocs.io/en/latest/index.html" | ||
Repository = "https://github.com/lvgig/tubular" | ||
Issues = "https://github.com/lvgig/tubular/issues" | ||
Changelog = "https://github.com/lvgig/tubular/CHANGELOG.md" | ||
|
||
[tool.ruff] | ||
# Same as Black. | ||
line-length = 88 | ||
|
||
# Assume Python 3.8. | ||
target-version = "py38" | ||
adamsardar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
[tool.ruff.lint] | ||
# Enable the pycodestyle (`E`) and Pyflakes (`F`) rules by default. | ||
# Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or | ||
# McCabe complexity (`C901`) by default. | ||
select = [ | ||
"A", | ||
"ANN", | ||
"ASYNC", | ||
"B", # bugbear | ||
"C4", | ||
"COM", | ||
"DTZ", | ||
"E", # pycodestyle | ||
"EM", | ||
"F", # Pyflakes | ||
"FA", | ||
"FLY", | ||
"I", | ||
"INT", | ||
"ISC", | ||
"NPY", | ||
"PD", | ||
"PERF", | ||
"PGH", | ||
"PIE", | ||
"PLC", | ||
"PLE", | ||
"PLW", | ||
"PYI", | ||
"Q", | ||
"RET", | ||
"RSE", | ||
"S", # Bandit | ||
"SIM", | ||
"SLOT", | ||
"T10", | ||
"TCH", | ||
"TID", | ||
"UP", | ||
"W", # pycodestyle warnings | ||
"YTT", | ||
] | ||
|
||
# Enabled to allow direct type comparisons using is and is not under E721 (see https://docs.astral.sh/ruff/rules/type-comparison/) | ||
preview = true | ||
|
||
# ignore E501 - linelength limit (covered by black except in docstrings) | ||
# and PD901 - use of df variable name | ||
ignore = ["E501", "PD901", "ANN101"] | ||
|
||
# Allow autofix for all enabled rules (when `--fix`) is provided. | ||
fixable = ["ALL"] | ||
unfixable = [] | ||
|
||
# Exclude a variety of commonly ignored directories. | ||
exclude = [".git", "__pycache__", "build", "dist", "source"] | ||
|
||
# Allow unused variables when underscore-prefixed. | ||
dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$" | ||
|
||
# Ignore `E402` (import violations) in all `__init__.py` file. | ||
[tool.ruff.lint.per-file-ignores] | ||
"__init__.py" = ["E402", "F401"] | ||
"tests/*" = ["ANN", "S101"] | ||
|
||
|
||
[tool.coverage.run] | ||
branch = true | ||
|
||
include = ["tubular/*"] | ||
|
||
omit = [ | ||
"tests/*", | ||
] | ||
|
||
[tool.coverage.report] | ||
|
||
show_missing = true | ||
|
||
fail_under = 80 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,79 @@ | ||
test-aide>=0.1.0 | ||
pandas>=1.5.0 | ||
scikit-learn>=1.2.0 | ||
pytest>=5.4.1 | ||
pytest-mock>=3.5.1 | ||
pytest-cov>=2.10.1 | ||
pre-commit==2.15.0 | ||
ruff==0.2.2 | ||
# | ||
# This file is autogenerated by pip-compile with Python 3.8 | ||
# by the following command: | ||
# | ||
# pip-compile --extra=dev --no-emit-index-url --no-emit-trusted-host --output-file=requirements-dev.txt pyproject.toml | ||
# | ||
cfgv==3.4.0 | ||
# via pre-commit | ||
coverage[toml]==7.6.0 | ||
# via pytest-cov | ||
distlib==0.3.8 | ||
# via virtualenv | ||
exceptiongroup==1.2.2 | ||
# via pytest | ||
filelock==3.15.4 | ||
# via virtualenv | ||
identify==2.6.0 | ||
# via pre-commit | ||
iniconfig==2.0.0 | ||
# via pytest | ||
joblib==1.4.2 | ||
# via scikit-learn | ||
nodeenv==1.9.1 | ||
# via pre-commit | ||
numpy==1.24.4 | ||
# via | ||
# pandas | ||
# scikit-learn | ||
# scipy | ||
packaging==24.1 | ||
# via pytest | ||
pandas==2.0.3 | ||
# via tubular (pyproject.toml) | ||
platformdirs==4.2.2 | ||
# via virtualenv | ||
pluggy==1.5.0 | ||
# via pytest | ||
pre-commit==2.15.0 | ||
# via tubular (pyproject.toml) | ||
pytest==8.2.2 | ||
# via | ||
# pytest-cov | ||
# pytest-mock | ||
# test-aide | ||
# tubular (pyproject.toml) | ||
pytest-cov==5.0.0 | ||
# via tubular (pyproject.toml) | ||
pytest-mock==3.14.0 | ||
# via | ||
# test-aide | ||
# tubular (pyproject.toml) | ||
python-dateutil==2.9.0.post0 | ||
# via pandas | ||
pytz==2024.1 | ||
# via pandas | ||
pyyaml==6.0.1 | ||
# via pre-commit | ||
ruff==0.2.2 | ||
# via tubular (pyproject.toml) | ||
scikit-learn==1.3.2 | ||
# via tubular (pyproject.toml) | ||
scipy==1.10.1 | ||
# via scikit-learn | ||
six==1.16.0 | ||
# via python-dateutil | ||
test-aide==0.1.1 | ||
# via tubular (pyproject.toml) | ||
threadpoolctl==3.5.0 | ||
# via scikit-learn | ||
toml==0.10.2 | ||
# via pre-commit | ||
tomli==2.0.1 | ||
# via | ||
# coverage | ||
# pytest | ||
tzdata==2024.1 | ||
# via pandas | ||
virtualenv==20.26.3 | ||
# via pre-commit |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - answered my own question by seeing that you install directly from the pyproject file.