Feature/equality transformer #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! could you also:
|
|
Hey @limlam96 - forgot changelog again!!! Updated now, and added inheritance from new base class to equality checker transformer (don't think date transformers have been refactored to use two cols yet) |
limlam96
reviewed
May 7, 2024
tubular/comparison.py
Outdated
| @@ -31,7 +31,7 @@ def __init__( | |||
| drop_original: bool = False, | |||
| **kwargs: dict[str, bool], | |||
| ) -> None: | |||
| super().__init__(columns=columns, **kwargs) | |||
| super().__init__(columns=columns, new_col_name=new_col_name, **kwargs) | |||
|
|
|||
| if not (isinstance(columns, list)): | |||
There was a problem hiding this comment.
can now delete lines 36:46 :)
limlam96
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked up second aspect of this ticket - #204
Added an additional base class for two columns transformers and an associated test script which inherits from TwoColum Init in base tests. Might have missed the mark a little on this one, so have set up as a draft.