Created generic two column init tests and tidied test_EqualityChecker #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, could you just add an entry to the changelog? |
Suree have done so now, also added ModeImputer comment to change log as did not do that when I refactored those tests |
Chip2916
changed the title
limlam96
approved these changes
May 1, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to address two outstanding issues
204, generic init class for two column transformers
205, bring EqualityChecker test in line with new format
Hopefully this new generic class can be used for many of the date transformers, which use two columns as an input. At this stage these transformers take two separate args which are combined into a list, rather than the EqualityChecker which takes a list with two objects. After speaking with @limlam96 agreed that updating the date transformers to take as single arg sits outside this ticket.
'test_columns_non_list_error' seems to fail if anything other than string passed to pytest.mark.parametrize due to EqualityChecker reference to BaseTransformer which only accepts str or list, might be missing something here.