Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mode imputer test overhaul #223

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Conversation

Chip2916
Copy link
Collaborator

@Chip2916 Chip2916 commented Apr 10, 2024

Initial changes to ModeImputer test - first view of Tubular code and tests so apologies if there are some mistakes. Have hopefully:

  • Removed redundant tests from test_ModeImputer.py
  • Added relevant tests to parent (test_BaseImputer.py)

@Chip2916 Chip2916 requested a review from limlam96 April 10, 2024 08:41
tests/conftest.py Outdated Show resolved Hide resolved
tests/imputers/test_BaseImputer.py Outdated Show resolved Hide resolved
tests/imputers/test_BaseImputer.py Outdated Show resolved Hide resolved
tests/imputers/test_ModeImputer.py Show resolved Hide resolved
tests/imputers/test_ModeImputer.py Show resolved Hide resolved
@Chip2916 Chip2916 marked this pull request as ready for review April 11, 2024 09:36
@limlam96 limlam96 merged commit beba8cd into main Apr 12, 2024
12 checks passed
@limlam96 limlam96 deleted the feature/mode_imputer_test_overhaul branch April 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants