edited mode imputed to work with all null columns when weights are pr… #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsardar
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Good catch. And a small PR that I'm happy to approve without revisions.
It opens a question of whether there is a number or fraction of entries that might be considered too small to estimate a replacement value and should therefore issue a warning too. Or should that be at least logged? One for #193?
|
Thanks! :) Yeah good point, suppose ideal behaviour in that scenario is as you say to raise a warning and leave it to user discretion whether to drop/fix/continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ovided
Previously this was causing an error. slightly niche scenario that was exposed by running small synthetic data samples through, but worth fixing