edited MeanResponseTransformer to convert category to float, fixed tests #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the contribution @limlam96! Idea and implementation look sound. This transformer is already a bit overcomplicated resulting in some difficult to interpret code and tests so most of my comments relate to avoiding making tests harder to read.
…_encoder_coerce_float
davidhopkinson26
approved these changes
Feb 6, 2024
davidhopkinson26
deleted the
feature/mean_response_encoder_coerce_float
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where category dtypes were preserved by this transformer, which is not desired behaviour. Edited to coerce outputs to float, as converting to numeric is ultimately the goal of this one.
Fixed tests, and edited some to put a category column through as part of testing.