You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MappingTransform.transform(X) tries to do things to X before actually checking that it is a dataframe and has the required columns.
I think the best solution would be to call the BaseTransformer.transform method at the start of transform, which you can do with X = super(BaseMappingTransformer, self).transform(X).
The text was updated successfully, but these errors were encountered:
On track to be fixed when mapping transformer is brought into the generic testing framework by the addition of a BaseTransformer.Transform call in this PR: #171
However, this leaves the issue that there are now two calls to BaseTransformer.transform (one explicit one implicit) in the MappingTransformer.transform method. I think this best solved my changing BaseMappingTransfomMixin - either by declaring it redundant or changing the name of it's transform method, allowing the BaseTransformer.transform method to be replaced by a super transform method and making this the only call to base transformer transform.
MappingTransform.transform(X)
tries to do things to X before actually checking that it is a dataframe and has the required columns.I think the best solution would be to call the BaseTransformer.transform method at the start of transform, which you can do with
X = super(BaseMappingTransformer, self).transform(X)
.The text was updated successfully, but these errors were encountered: