Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nominal transformer input checks #163

Open
TommyMatthews opened this issue Jan 11, 2024 · 1 comment
Open

Refactor nominal transformer input checks #163

TommyMatthews opened this issue Jan 11, 2024 · 1 comment
Labels
feature New feature or request

Comments

@TommyMatthews
Copy link
Contributor

For OrdinalEncodingTransformer and NominalToIntegerTransformer, we currently have to call a data check that from BaseTransformer.transform before you call check mappable rows from BaseNominalTransformer. BaseTransformer.transform is then called in full later in the method, leading to duplication of data checks. We would ideally refactor the code so that this isn't the case.

See this issue for more information

@TommyMatthews
Copy link
Contributor Author

TommyMatthews commented Feb 7, 2024

This issue is caused by the slightly confusing nature of the tubular BaseMappingTransformMixin and how it overwrites the transform method, similar to the comment on this issue: #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant