You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For OrdinalEncodingTransformer and NominalToIntegerTransformer, we currently have to call a data check that from BaseTransformer.transform before you call check mappable rows from BaseNominalTransformer. BaseTransformer.transform is then called in full later in the method, leading to duplication of data checks. We would ideally refactor the code so that this isn't the case.
This issue is caused by the slightly confusing nature of the tubular BaseMappingTransformMixin and how it overwrites the transform method, similar to the comment on this issue: #146.
For
OrdinalEncodingTransformer
andNominalToIntegerTransformer
, we currently have to call a data check that fromBaseTransformer.transform
before you callcheck mappable rows
fromBaseNominalTransformer
.BaseTransformer.transform
is then called in full later in the method, leading to duplication of data checks. We would ideally refactor the code so that this isn't the case.See this issue for more information
The text was updated successfully, but these errors were encountered: