Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ruff rulse ANN flake8-annotations #116

Closed
davidhopkinson26 opened this issue Jul 11, 2023 · 1 comment
Closed

Apply ruff rulse ANN flake8-annotations #116

davidhopkinson26 opened this issue Jul 11, 2023 · 1 comment
Assignees
@Sarah-TaylorKnight
Labels
CI improvements to continuous integration

Comments

@davidhopkinson26
Copy link
Contributor

https://beta.ruff.rs/docs/rules/#flake8-annotations-ann

make code compliant with rule set and then add to ruleset in .ruff.toml. If appropriate identify specific rules or parts of code to exclude.

2547 errors found for missing annotations.

This is a big one, happy to take contributions by module or individual script rather than addressing entire package in one go.
@davidhopkinson26 davidhopkinson26 added the CI improvements to continuous integration label Jul 11, 2023
@davidhopkinson26 davidhopkinson26 mentioned this issue Jul 13, 2023
Open
@Sarah-TaylorKnight Sarah-TaylorKnight self-assigned this Jul 19, 2023
adamsardar added a commit that referenced this issue Dec 29, 2023
@adamsardar
Merge pull request #128 from lvgig/feature/116-ann-flake8-annotations
df6188f 
Adding type hints across codebase. Closes #116 #137
@adamsardar
Copy link
Contributor

Closed by #128

@adamsardar adamsardar mentioned this issue Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sarah-TaylorKnight Sarah-TaylorKnight

Labels
CI improvements to continuous integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamsardar @Sarah-TaylorKnight @davidhopkinson26