Resolve compilation issues with spdlog and newer fmtlib (external) #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Øystein Sture <[email protected]>
This was referenced Jul 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit casting of enum class to integers have been disabled in fmt v8.1.0 and newer, which causes depthai-core compilation to fail when using external fmtlib with spdlog. This PR resolves that through explicit casts and also corrects an include which bypasses the SPDLOG_FMT_EXTERNAL macro.
Related fmtlib issue: fmtlib/fmt#1841
Signed-off-by: Øystein Sture [email protected]