Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 4 Support #19

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Craft 4 Support #19

merged 3 commits into from
Aug 22, 2022

Conversation

khamer
Copy link
Contributor

@khamer khamer commented May 31, 2022

This PR just adds the minor changes required for Craft 4 support. The changes also requires PHP 8, consistent with the syntax changes required and Craft 4's minimum requirements.

I'd probably also suggest renaming the repo to craft-codemirror from craft3-codemirror, as I don't think a separate fork is required for Craft 4 support, and it'd only make sense to maintain separate branches if you want to continue to support a version that doesn't require PHP 8.

@khamer khamer mentioned this pull request Aug 15, 2022
@luwes
Copy link
Owner

luwes commented Aug 22, 2022

thanks for the contribution!

@luwes luwes merged commit 76df9b5 into luwes:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants