Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Fix inconsistent usage between name and instance #360

Merged
merged 2 commits into from
Oct 4, 2014

Conversation

martinb3
Copy link
Collaborator

@martinb3 martinb3 commented Oct 2, 2014

This was breaking since I copy-pasta'd @instance everywhere, but some of the resources & providers use @name and some call that same variable @instance. We need testing!

This was breaking since I copy-pasta'd @instance everywhere, but some of the resources & providers use @name and some call that same variable @instance.
martinb3 added a commit to martinb3-cookbooks/elkstack that referenced this pull request Oct 2, 2014
- Fix an upstream logstash cookbook issue, contribute it back upstream ([#360](lusis/chef-logstash#360)). Once that is merged, we can go back to upstream.
- Move agent attributes out more, to be their own explicit settings.
paulczar added a commit that referenced this pull request Oct 4, 2014
Fix inconsistent usage between name and instance
@paulczar paulczar merged commit 3539a90 into lusis:master Oct 4, 2014
@martinb3 martinb3 deleted the fix_instance_or_name branch October 4, 2014 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants