No more assert on result #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling - Replaced assertions throughout multiple functions and tests with directly unwrapping results for better error handling and clarity on failures. - Applied this change to methods like `prove_step`, `verify`, `test_inner`, and in areas like RecursiveSNARK, CompressedSNARK, and test functions across different scripts. - Enhanced the error feedback mechanism during benchmarks for RecursiveSNARK, and CompressedSNARK. - Simplified code further by removing unnecessary checks and variable assignments, and performing inline verification with cleanercode. - Updated `.cargo/config.toml` with a new project-wide Clippy lint rule for assertion on result states.
adr1anh
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assertion failure on a Result cannot output the useful message of the error.
This removes the systematic pattern of asserting on result states, specially when it comes to tests / benches.
Prohibits them for good measure, using clippy.