Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nova forward ports #126

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Nova forward ports #126

merged 5 commits into from
Nov 16, 2023

Conversation

huitseeker
Copy link
Contributor

srinathsetty and others added 4 commits November 15, 2023 23:36
@srinathsetty @huitseeker
Simplify Group trait (#259)
c9cc0de 
* simplify Group trait

* fix clippy

* further simplifications

* fix Copy
@srinathsetty @huitseeker
Cut duplicate code (#261)
b6c4e1a 
* cut duplicate code

* bound --> bind for clarity

* expose asm feature
@huitseeker
test: check test_pp_digest with asm feature in CI
a779b8d
@srinathsetty @huitseeker
expose size of the base field (#262)
bcbd35c
@huitseeker huitseeker force-pushed the moar_nova_forward_ports branch from 1cddfba to bcbd35c Compare November 16, 2023 04:37
adr1anh
adr1anh reviewed Nov 16, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
adr1anh
adr1anh reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@adr1anh adr1anh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think it's important to understand why the asm feature would generate different values.

@huitseeker huitseeker added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit 8adb3ce Nov 16, 2023
3 checks passed
@huitseeker huitseeker deleted the moar_nova_forward_ports branch November 16, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adr1anh adr1anh adr1anh approved these changes

@porcuquine porcuquine Awaiting requested review from porcuquine

@mpenciak mpenciak Awaiting requested review from mpenciak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huitseeker @adr1anh @srinathsetty