Merged
Conversation
Call `groth16::create_random_proof` directly instead of having a helper method. This reduces one level of indirection and 10 lines of code.
There are cache keys that aren't actually used and an instanceo of a manually written cache key, which is error prone. This commit cleans things a bit up.
Contributor
Author
|
I made a small CI change (not sure if it was needed), but at least CI is green now :) |
porcuquine
approved these changes
Dec 22, 2022
Contributor
porcuquine
left a comment
porcuquine
left a comment
There was a problem hiding this comment.
Looks good. Thanks, @vmx.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just a small refactor I came across when I was looking through the Lurk source cod and trying to figure out what was going on.
I also made the README a bit clearer on how to get started with the tests.
If you want two separate PRs, let me know.