Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont require mandatory columns when deleting in excel import 183507263 #679

Conversation

MLumme
Copy link
Contributor

@MLumme MLumme commented Nov 21, 2024

Old pivotal task here: https://www.pivotaltracker.com/story/show/183507263
Testable here: https://183507263.dev.laji.fi/

Bypassed excel import mandatory column validation inside the excel importer if the row is being deleted.

@rpulkka rpulkka self-assigned this Nov 22, 2024
@rpulkka rpulkka self-requested a review November 22, 2024 07:32
Copy link
Contributor

@rpulkka rpulkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@rpulkka rpulkka added this to the Release 78 milestone Nov 22, 2024
@Blodir Blodir merged commit 7271fe6 into development Nov 25, 2024
1 check passed
@Blodir Blodir deleted the dont-require-mandatory-columns-when-deleting-in-excel-import-183507263 branch November 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants