Strict TS config - Week 1 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorin
reviewed
Oct 22, 2024
| return isTechnical && isNew; | ||
| }); | ||
| if (news) { | ||
| this.technicalNews = news?.filter(newsItem => { |
There was a problem hiding this comment.
This could be changed to this.techicalNews = (news || []).filter(..., then the if clause can be removed and the type can be array (technicalNews: News[] = [];)
aorin
reviewed
Oct 22, 2024
|
|
||
| downloadedDocumentId: string; | ||
| downloadedDocumentId = ''; |
There was a problem hiding this comment.
Instead of setting a default value, you could make the variable optional downloadedDocumentId?: string or set the type as downloadedDocumentId: string | undefined
aorin
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Looks fine to me. In the future, it might be better/easier to just change the types and not any values. A change like year: string -> year = '' could possible break something, for example if there was a check like if (year === undefined) somewhere. But I didn't see anything like that here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could someone review my first week's strict TS config changes? Not sure what to do in situations where a type is now possibly undefined, and it isn't addressed in the code, (see newline 220 on own-datatable.component.ts, or code in technical-news-dumb.component.ts).