Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update #166

Merged
merged 15 commits into from
Aug 19, 2021
Merged

Dependency update #166

merged 15 commits into from
Aug 19, 2021

Conversation

olzraiti
Copy link
Member

@olzraiti olzraiti commented Aug 17, 2021

Updated the deps by following https://update.angular.io/ with app complexity "advanced" and migration being from 11 to 12.

  1. Had to run ng update with force & allow-dirty flags: ng update @angular/core@12 @angular/cli@12 @nguniversal/builders @circlon/angular-tree-component @ng-select/ng-select apollo-angular @ng-toolkit/universal --allow-dirty --force
  2. There were some breaking changes and the compiler detected some existing errors better, so I had to do the following changes:
  • Use math.div for sass divisions
  • Deleted haseka-form-list components, since the compiler started complaining about some stuff there and they're not used anywhere
  • Added some stricter typing for components that the compiler complained about (transfer-http-cache.interceptor.ts and graph-ql.service.ts)
  1. Ran npm update
  2. Checked all items in the angular update check list (from the link in the top)

@aorin
Copy link
Contributor

aorin commented Aug 18, 2021

Do you have any problem running npm run build:prod? I got this kind of error: "Index html generation failed. property missing ':'". (Might be related to this issue)

@olzraiti
Copy link
Member Author

Yes I get the same error. I didn't try any build scripts yet, good that you tried that out. That issue seems relevant indeed!

@olzraiti
Copy link
Member Author

I dug a solution from that issue discussion. Didn't test yet to actuallly build a local version to see if the solution has any side effects. We should try to remember to revert that commit in the future if the issue is fixed.

@olzraiti
Copy link
Member Author

I tested the production ssr build locally and haven't found any style issues that the options.styles.inlineCriticals config could have caused.

@esko-piirainen esko-piirainen merged commit f28189a into development Aug 19, 2021
@olzraiti olzraiti deleted the ng-update-210817 branch April 13, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants