Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Remove record ID and simplify record store #62

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

andrewwormald
Copy link
Collaborator

@andrewwormald andrewwormald commented Oct 30, 2024

The goal of this MR is to simplify workflow a bit. The goal is to reduce mental complexity by removing the ID field for Records. Originally Workflow considers workflow name + foreignID + runID as a unique key for each run. As time has gone on I have thought more and more around the scalability of UUID v4 and the the low collision probability that it has even at the quantillion range is only reaching 50% probability.

Considering this and the desire to simplify the data model I am proposing that the runID is made a globally unique identifier for a workflow run which also aligns it more to it's name of RunID instead of using a combination of workflow name + foreignID + runID.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests, if appropriate.

New Feature Submissions:

  1. Does your submission pass tests?
  2. Did you install pre-commit hooks before committing?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@andrewwormald andrewwormald marked this pull request as ready for review October 31, 2024 14:44
Copy link

@andrewwormald andrewwormald merged commit 81ae418 into main Nov 1, 2024
6 checks passed
@calentang
Copy link

hi,that very great code for workflow,can you support release of this luno/workflow project,thanks!

@andrewwormald
Copy link
Collaborator Author

HI @calentang, thank you! We will start tracking versions going forward. Thanks for reaching out!

Please see: https://github.com/luno/workflow/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants