workflow: Remove record ID and simplify record store #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this MR is to simplify workflow a bit. The goal is to reduce mental complexity by removing the ID field for Records. Originally Workflow considers
workflow name
+foreignID
+runID
as a unique key for each run. As time has gone on I have thought more and more around the scalability of UUID v4 and the the low collision probability that it has even at the quantillion range is only reaching 50% probability.Considering this and the desire to simplify the data model I am proposing that the
runID
is made a globally unique identifier for a workflow run which also aligns it more to it's name of RunID instead of using a combination ofworkflow name
+foreignID
+runID
.All Submissions:
Checklist before requesting a review
New Feature Submissions:
Changes to Core Features: