Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Reduce direct dependencies #2

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

andrewwormald
Copy link
Collaborator

The idea here is to clarify what the main package uses in terms of dependencies and provide clarity of what each adapter brings. This allows for the user to not have indirect dependencies from adapters that it's not using such as kafka if not using kafka or reflex if not using reflex

Copy link

@echarrod
Copy link
Contributor

Downside of this would be if we end up doing semantic versioning (rather than just having users update their digest), the sub-modules would all need to be managed and released separately. I would like to do this eventually for nearly all our modules.

And the benefit of this is that users won't import as many indirect dependencies when they use one of these?

Just considering the trade-off

@andrewwormald
Copy link
Collaborator Author

Downside of this would be if we end up doing semantic versioning (rather than just having users update their digest), the sub-modules would all need to be managed and released separately. I would like to do this eventually for nearly all our modules.

And the benefit of this is that users won't import as many indirect dependencies when they use one of these?

Just considering the trade-off

Yeah the main thing is that example and adapters are not part of the workflow module. The adapters themselves can exist as their own modules not just packages of the workflow module. They themselves can have their own versioning but will always need to implement the specification that the workflow module dictates.

@andrewwormald andrewwormald merged commit 6f20b02 into main Jul 15, 2024
1 check passed
@andrewwormald andrewwormald deleted the andrew-removeIndirectDependanciesToOwnModules branch July 15, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants