Merged
Conversation
Owner
|
Please rebase. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
lunny/webauthn
branch
from
d085b5e to
ad7ea73
Compare
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
reviewed
Jan 11, 2022
| type WebAuthnCredential struct { | ||
| ID int64 `xorm:"pk autoincr"` | ||
| Name string `xorm:"unique(s)"` | ||
| LowerName string |
Owner
There was a problem hiding this comment.
So, the tag xorm:"unique(s)" should be in the LowerName field.
lunny
reviewed
Jan 11, 2022
| // Ensure user is in a WebAuthn session. | ||
| idSess := ctx.Session.Get("twofaUid") | ||
| if idSess == nil { | ||
| idSess, ok := ctx.Session.Get("twofaUid").(int64) |
Owner
There was a problem hiding this comment.
It will panic if there is no session named twofaUid.
Author
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
The use of the x, ok := something.(otherthing) form prevents the NPE if something is a nil interface{}
|
link go-gitea#17957 |
Author
|
OK i've fixed the ci and I've fixed a few more bugs with suburl and users. |
Owner
|
Let's move on. |
Author
|
Somehow all of the commits to this branch did not make it across. This is weird. |
Author
|
I'm just gonna push these up directly to lunny/webauthn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.