Skip to content

Commit

Permalink
fix duplicated feed (go-gitea#2370)
Browse files Browse the repository at this point in the history
  • Loading branch information
lunny committed Aug 28, 2017
1 parent f916aa0 commit ba531e0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
9 changes: 1 addition & 8 deletions models/action.go
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,6 @@ type GetFeedsOptions struct {
IncludePrivate bool // include private actions
OnlyPerformedBy bool // only actions performed by requested user
IncludeDeleted bool // include deleted actions
Collaborate bool // Include collaborative repositories
}

// GetFeeds returns actions according to the provided options
Expand All @@ -733,13 +732,7 @@ func GetFeeds(opts GetFeedsOptions) ([]*Action, error) {
cond = cond.And(builder.In("repo_id", repoIDs))
}

var userIDCond builder.Cond = builder.Eq{"user_id": opts.RequestedUser.ID}
if opts.Collaborate {
userIDCond = userIDCond.Or(builder.Expr(
"repo_id IN (SELECT repo_id FROM `access` WHERE access.user_id = ?)",
opts.RequestedUser.ID))
}
cond = cond.And(userIDCond)
cond = cond.And(builder.Eq{"user_id": opts.RequestedUser.ID})

if opts.OnlyPerformedBy {
cond = cond.And(builder.Eq{"act_user_id": opts.RequestedUser.ID})
Expand Down
1 change: 0 additions & 1 deletion routers/user/home.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ func Dashboard(ctx *context.Context) {
retrieveFeeds(ctx, models.GetFeedsOptions{RequestedUser: ctxUser,
IncludePrivate: true,
OnlyPerformedBy: false,
Collaborate: true,
IncludeDeleted: false,
})
if ctx.Written() {
Expand Down
1 change: 0 additions & 1 deletion routers/user/profile.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ func Profile(ctx *context.Context) {
retrieveFeeds(ctx, models.GetFeedsOptions{RequestedUser: ctxUser,
IncludePrivate: showPrivate,
OnlyPerformedBy: true,
Collaborate: true,
IncludeDeleted: false,
})
if ctx.Written() {
Expand Down

0 comments on commit ba531e0

Please sign in to comment.