Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable: OS X build is broken #318

Closed
afrocheese opened this issue Mar 11, 2019 · 2 comments
Closed

unstable: OS X build is broken #318

afrocheese opened this issue Mar 11, 2019 · 2 comments

Comments

@afrocheese
Copy link
Contributor

The OS X build fails to a bug in golang (golang/go#25908).

➜  usercorn git:(unstable) make
mkdir -p .gopath/src/github.com/lunixbochs
ln -s ../../../.. .gopath/src/github.com/lunixbochs/usercorn
go get -u github.com/chzyer/readline github.com/golang/snappy github.com/jroimartin/gocui github.com/keystone-engine/keystone/bindings/go/keystone github.com/lunixbochs/argjoy github.com/lunixbochs/capstr github.com/lunixbochs/fvbommel-util/sortorder github.com/lunixbochs/ghostrace/ghost/memio github.com/lunixbochs/ghostrace/ghost/sys/num github.com/lunixbochs/luaish github.com/lunixbochs/luaish-luar github.com/lunixbochs/luaish/parse github.com/lunixbochs/readline github.com/lunixbochs/struc github.com/mgutz/ansi github.com/pkg/errors github.com/shibukawa/configdir github.com/unicorn-engine/unicorn/bindings/go/unicorn
rm -f usercorn
go build -o usercorn ./go/cmd/main
# _/tmp/usercorn/go/cmd/main
/tmp/usercorn/deps/go-x86_64-Darwin/pkg/tool/darwin_amd64/link: /tmp/usercorn/deps/go-x86_64-Darwin/pkg/tool/darwin_amd64/link: combining dwarf failed: Unknown load command 0x32 (50)

Let me know if you'd like me to just wrap this into a PR instead.

diff --git a/Makefile b/Makefile
index 7841386..1ba2aea 100644
--- a/Makefile
+++ b/Makefile
@@ -32,7 +32,7 @@ ifeq "$(OS)" "Darwin"
 endif

 # figure out if we can download Go
-GOVERSION=1.10.1
+GOVERSION=1.10.8
 ifeq "$(ARCH)" "x86_64"
        ifeq "$(OS)" "Darwin"
                GOURL = "https://storage.googleapis.com/golang/go$(GOVERSION).darwin-amd64.tar.gz"
@lunixbochs
Copy link
Owner

Sure, can you wrap this in a PR?

@lunixbochs
Copy link
Owner

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants