Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Some complain]: Roslyn Source generator support badly for net8.0 #5

Closed
Sieluna opened this issue Mar 17, 2024 · 1 comment
Closed

[Some complain]: Roslyn Source generator support badly for net8.0 #5

Sieluna opened this issue Mar 17, 2024 · 1 comment
Assignees
@sicusa @Sieluna
Labels
enhancement New feature or request

Comments

@Sieluna
Copy link
Member

Sieluna commented Mar 17, 2024 •
edited
Loading

Description

I think it is good to remove the net8.0 from compile target. Here I will provide some comparisons:

  1. The nuget will load netstandard 2.0 target only (didn't upload the net8.0).
    image

  2. The net8.0 build will use locally only. This will cause a analyse fault for Roslyn analyser. (You can reproduce the effect by reclone the project from git)
    image
    image

  3. Let's remove the net8.0 at
    https://github.com/sicusa/Sia.NET/blob/c71a9bceb87054facb5f28765dbafd5323460aca/Sia.CodeGenerators/Sia.CodeGenerators.csproj#L4

+   <TargetFramework>netstandard2.0</TargetFramework>
-    <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
  1. No any error message from Roslyn analyser.
  2. IDE can recognize the generated source successfully.
    image
    image
Sieluna added a commit to Sieluna/Sia.NET that referenced this issue Mar 17, 2024
@Sieluna
reduce error message from Roslyn analyser (lunditoph-siago#5)
5fd3343
Sieluna added a commit to Sieluna/Sia.NET that referenced this issue Mar 17, 2024
@Sieluna
Revert "reduce error message from Roslyn analyser (lunditoph-siago#5)"
99a08ea 
This reverts commit 5fd3343.
Sieluna added a commit to Sieluna/Sia.NET that referenced this issue Mar 17, 2024
@Sieluna
reduce error message from Roslyn analyser (lunditoph-siago#5)
e5638c7
sicusa added a commit that referenced this issue Mar 18, 2024
@sicusa
Merge pull request #6 from Sieluna/patch-2
87f47e9 
Reduce error message from Roslyn analyser (#5)
@sicusa sicusa added the enhancement New feature or request label Mar 18, 2024
@sicusa sicusa closed this as completed Mar 18, 2024
@sicusa
Copy link
Collaborator

sicusa commented Mar 18, 2024

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sicusa sicusa

@Sieluna Sieluna

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sicusa @Sieluna