This repository was archived by the owner on Oct 6, 2025. It is now read-only.
add missing #include <cassert>#45
Merged
luncliff merged 1 commit intoluncliff:masterfrom Jan 13, 2020
Merged
Conversation
Owner
|
Appreciate the PR. the change looks fine :D |
luncliff
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue while updating the GSL on vcpkg. microsoft/vcpkg#9624
Note, the current version on vcpkg, 74467cb (release 1.4.3), is also incompatible with current GSL versions.
The code resides there in a different file: concrt.cpp
When you merge this I'll submit the resulting HEAD to vcpkg, unless you suggest otherwise.